fix: use placeholder-free key for suggestion display label (#273)#369
Merged
JohnMcLear merged 1 commit intomainfrom Apr 17, 2026
Merged
fix: use placeholder-free key for suggestion display label (#273)#369JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
The display-suggestion template's label used
`ep_comments_page.comments_template.suggested_change_from`, whose
English value is "Suggested change from \"{{changeFrom}}\" to
\"{{changeTo}}\"". The span had no `data-l10n-args`, so the
{{changeFrom}} / {{changeTo}} placeholders rendered as literal text
when replying with a suggestion.
Introduce a new key
`ep_comments_page.comments_template.suggested_change_from_label` that
is plain "Suggested change from" (no placeholders). The adjacent
`.from-value` / `.to-value` spans already render the quoted values, so
the label should only carry the static prefix.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan