fix: drop require of removed ep_etherpad-lite/static/js/browser (#169)#370
Merged
JohnMcLear merged 1 commit intomainfrom Apr 17, 2026
Merged
fix: drop require of removed ep_etherpad-lite/static/js/browser (#169)#370JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
Etherpad 2.x removed the `static/js/browser` helper during the esbuild refactor. Requiring it at the top of `static/js/index.js` made the entire module fail to load on the server — visible as "Cannot find module 'ep_etherpad-lite/static/js/browser'" (previously "window is not defined" on older Etherpad versions that did ship the helper but threw while evaluating it in a Node context). That in turn broke the \`/admin/plugins/info\` troubleshooting page, which tries to require every client hook module for reporting. The only use of `browser` was a chrome/firefox guard around the copy/ cut/paste handlers; every currently supported browser implements those events, so drop both the require and the guard. The handler block is always registered now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan