fix: refresh color dropdown when UI language changes (#21)#133
Merged
JohnMcLear merged 1 commit intomainfrom Apr 17, 2026
Merged
fix: refresh color dropdown when UI language changes (#21)#133JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
The color select is wrapped in niceSelect, which renders its own DOM
copy of the <select> at init time. html10n rewrites the option text in
place for the new locale, but niceSelect does not observe those
mutations, so the user kept seeing the previous language's labels in
the dropdown.
Subscribe to \`html10n.localized\` from postAceInit and call
\`niceSelect('update')\` on the underlying select so the custom dropdown
re-reads the translated options.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21. The color select is wrapped in niceSelect, which renders its own DOM copy of the at init time. html10n rewrites option text in place for the new locale, but niceSelect does not observe those mutations, so the dropdown kept showing the previous language. Subscribe to html10n.localized and call niceSelect('update') to refresh the custom dropdown. Backend spec asserts the wiring is present.