a11y: restore aria-label on <select> (html10n cannot auto-populate)#137
Merged
JohnMcLear merged 1 commit intomainfrom May 10, 2026
Merged
a11y: restore aria-label on <select> (html10n cannot auto-populate)#137JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
The earlier PR removed aria-label from this <select> assuming etherpad's html10n would auto-populate it from data-l10n-id. It does not — the auto-population path at html10n.ts:665-678 only fires when an element has no children (or when the data-l10n-id ends in a recognized attribute suffix). <select> elements always have <option> children, so the fallback is bypassed and the element loses its accessible name. Restoring the hardcoded aria-label as a stopgap. The proper fix is to extend html10n to populate aria-label for form-controllable elements.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the
aria-labelremoval on the<select>element introduced by the previous Phase 3a sweep (#136).Why this needed reverting: etherpad's html10n only auto-populates
aria-labelfor elements with no children (or when the data-l10n-id has an attribute suffix like.title).<select>elements always have<option>children, so the fallback athtml10n.ts:665-678is bypassed. After the previous PR, the<select>was left with no accessible name at all.This is a stopgap — the hardcoded English aria-label is back, which is bad for translated UI but better than no accessible name. The proper fix is a small change to
html10n.tsto populate aria-label on form-controllable elements (<select>,<input>,<textarea>) regardless of children. That should be a follow-up PR against ether/etherpad.