helpers: adopt padToggle for Spell Check setting#124
Merged
Conversation
Replaces the manual settings-panel checkbox + cookie wiring with padToggle from ep_plugin_helpers, which gives parallel User Settings / Pad Wide Settings checkboxes for free and owns markup, storage, broadcast, enforce, and i18n. Also drops the eejsBlock_dd_view "Spell Check" entry. That entry rendered hardcoded English text inside `<a href='#' onclick=…>`, which was an i18n hole, an a11y hole (anchor-as-button), and CSP- hostile, and it bypassed the helper's state machine. The User Settings panel is the canonical home for the toggle and now offers both per-user and pad-wide control. Backward compat: existing installs that set `ep_spellcheck.disabledByDefault: true` keep their behavior — the plugin's loadSettings translates the legacy key into the helper's `defaultEnabled` before delegating. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eejsBlock_mySettings+ cookie wiring withpadTogglefromep_plugin_helpers. Gives parallel User Settings / Pad Wide Settings checkboxes for free and centralizes markup, storage, broadcast, enforce, and i18n.eejsBlock_dd_view"Spell Check" entry. It rendered hardcoded English text inside<a href='#' onclick=…>, which was an i18n hole, an a11y hole (anchor-as-button), CSP-hostile, and bypassed the helper's state machine. The User Settings panel is the canonical home and now offers both per-user and pad-wide control.static/js/spellcheck.jsto usepadToggle.init({onChange})instead of hand-rolled cookie restore + click binding.ep_spellcheck.disabledByDefault: trueto the helper'sdefaultEnabledinloadSettingsso existing installs keep their current behavior.Test plan
pnpm run linteejsBlock_mySettingsproduces valid<input>/<label>markup withdata-l10n-id, legacydisabledByDefaulttranslates todefaultEnabled.#innerdocbody; re-enabling re-enables it.enablePluginPadOptions: true), toggling Pad Wide Settings broadcasts to other users.🤖 Generated with Claude Code