fix: align @fortawesome/* and react/react-dom so the deploy build compiles#364
Merged
JohnMcLear merged 1 commit intomasterfrom Apr 17, 2026
Merged
Conversation
…ompiles Two transitive version conflicts were breaking the Deploy etherpad docs to GitHub Pages workflow: 1. \`@fortawesome/free-brands-svg-icons\` was pinned to \`^7.2.0\` while the other \`@fortawesome/*\` deps were \`^7.0.0\`. pnpm resolved two copies of \`@fortawesome/fontawesome-common-types\` (7.0.0 and 7.2.0), and the TypeScript build failed with \`Type 'IconDefinition' is not assignable to type 'IconProp'. ... Type '"fagt"' is not assignable to type 'IconPrefix'\`. 2. \`react\` was \`^19.2.4\` and \`react-dom\` was \`^19.2.0\`, so pnpm resolved them to different minors (19.2.4 and 19.2.0) and Next bailed out with "Incompatible React versions: The react and react-dom packages must have the exact same version". Bump all four \`@fortawesome/*\` packages to \`^7.2.0\` and both \`react\` / \`react-dom\` to \`^19.2.5\` so pnpm resolves a single version of each. \`pnpm run build\` now completes locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy workflow has been failing on every push since the last dependency updates. Two transitive version conflicts to sort:
@fortawesome/free-brands-svg-iconswas pinned at^7.2.0while the other FA packages were^7.0.0. pnpm ended up resolving two copies of@fortawesome/fontawesome-common-types(7.0.0 and 7.2.0), and the TypeScript build failed withType '"fagt"' is not assignable to type 'IconPrefix'.reactwas^19.2.4andreact-domwas^19.2.0. pnpm picked different minors (19.2.4 / 19.2.0) and Next aborted with "Incompatible React versions".Bump all four
@fortawesome/*packages to^7.2.0and bothreact/react-domto^19.2.5.pnpm run buildcompletes locally with the new lockfile.