Skip to content

fix(release): exclude etherpad/bin/ from extraResources (Windows 7za) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
May 12, 2026
Merged

fix(release): exclude etherpad/bin/ from extraResources (Windows 7za) #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/desktop/build/electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ extraResources:
- '!**/tests/**'
- '!**/.git/**'
- '!**/playwright.config.ts'
# Etherpad's `bin/` directory contains operator CLI utilities
# (compactPad, importSqlFile, etc.) that the embedded server
# never invokes at runtime. Its package.json declares a pnpm
# workspace symlink to `../src`, and the nested
# `bin/node_modules/ep_etherpad-lite/node_modules/<dep>` paths
# are pnpm symlinks too. tar/zip preserves the symlinks but
# Windows file systems don't follow them after extraction, so
# 7za scan-fails with "system cannot find the path specified"
# for every dep and exits 1 (warning-as-error), breaking the
# Windows NSIS build. Excluding the whole dir is fine —
# findBundledEtherpadDir + node/server.ts only need src/.
- '!bin/**'

asar: true
asarUnpack:
Expand Down
Loading