Conversation
Member
Author
|
Note that before this is merged the removal of tests should be taken back out, they are removed to make testing the PR easier.
Once the windows build is fixed we can finish this PR off. |
568bc9a to
2d8129d
Compare
Intentionally remove all other tests, to make windows one run quicker and fail faster and not take up CI time.
2d8129d to
9ced2e0
Compare
Required for tests to pass in windows CI, maybe.
This reverts commit 9ced2e0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #4787 it's clear we need some CI for running Etherpad Server on Windows server and run some backend tests(no need for frontend).
Todo:
importExportGetPost.js<-- they don't fail on my local windows machine! 🍡