add version string to package requests#3
Merged
JohnMcLear merged 1 commit intoether:masterfrom Mar 19, 2021
Merged
Conversation
This was referenced Mar 19, 2021
Merged
rhansen
pushed a commit
that referenced
this pull request
Jul 31, 2021
add version string to package requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
although we're going to abandon this package soon, this should be fixed imo. require cause GET requests but without a version string. This results in multiple downloads in case we download a package also via script tags, which we do, because we need some packages inside inner/outer/parent. Before this change we needed to pay special attention to the order in which we write script tags/require, but now it does not matter anymore.