Timeslider is broken for pads with spaced names

[jhollinger]

Everything seems to support pads with spaced names/ids except for the Timeslider UI. For a url like /p/my awesome pad with spaces/timeslider, the Timeslider does not scroll through any revisions, the Play button does nothing, and the Back rev/Forward rev buttons are disabled.

[hikinggrass]

this problem will be fixed easily (just waiting for my pull request to be accepted) - at the moment you can just apply this fix manually: https://github.com/Pita/etherpad-lite/pull/136/files

[jhollinger]

Awesome, looks like that takes care of it.

[jhollinger]

Looks like this was never pulled in. Still broken.

[Wikinaut]

hello, I also will propose soon a fix to index.html to replace spaces in padnames by underscore characters (like MediaWiki does),

See also Wikinaut@5ea8dd6

Replace unescape() by decodeURIComponent() to allow padnames and Uris with non-ASCII characters.

[Pita]

I close this cause afaik its solved. If not feel free to open it again

[Wikinaut]

In my version it is solved, but not in upstream/master. (I cannot re-open issues you have closed).

[jhollinger]

It seems to be solved for me in the latest pulls from master. I'm curious, what's not working for you?

[Wikinaut]

The space problem is indeed solved, but not the Umlaut problems, in general, UTF-8 in padnames problem.

I admit, that the character encoding problem was not the topic of this bug issue.

Instead of unescape(), you need to use decodeURIComponent() as shown in Wikinaut@5ea8dd6 and
a clean solution for rewriting and using underscores instead of spaces in Urls and padnames should be part of the core software.

So that, if someone opens a pad "My pad" this should always be represented by links such as http://www.example.com/p/My_pad this and is always correctly treated. I mean, space, %20 and underscore should always be treated as "" inside the program, and the resulting urls should only show "" instead of space or %20. HTML page titles should however show a space instead of underscore or %20.

[Pita]

@Wikinaut I merged your commit, see here. It should be solved Pita/etherpad-lite@5ea8dd6

[jhollinger]

Was this fix reverted? I don't see @Wikinaut's changes in a fresh pull from upstream/master, and spaced pad's timesliders aren't functioning. Don't see it in the commit history, either.