Calling setHTML without valid HTML causes TypeError crash

[Miserlou]

getHtml, getText and setText all work, however, setHTML causes a fatal crash, if the HTML is invalid. Here's the traceback:

[2013-02-04 16:43:51.682] [INFO] API - REQUEST, v1:setHTML, {"apikey":"XXX","html":"asdf","padID":"gsBqktafF5JzdjF"}

[2013-02-04 16:43:51.697] [ERROR] console - TypeError: Object [ null ] has no method 'getAttribute'
at Object.nodeAttr (/home/tuttle/Projects/etherpad-lite/src/static/js/contentcollector.js:69:16)
at Object.collectContent (/home/tuttle/Projects/etherpad-lite/src/static/js/contentcollector.js:378:23)
at Object.setPadHTML (/home/tuttle/Projects/etherpad-lite/src/node/utils/ImportHtml.js:41:6)
at /home/tuttle/Projects/etherpad-lite/src/node/db/API.js:275:16
at Object.getPad (/home/tuttle/Projects/etherpad-lite/src/node/db/PadManager.js:94:5)
at /home/tuttle/Projects/etherpad-lite/src/node/db/API.js:625:18
at Object.callback (/home/tuttle/Projects/etherpad-lite/src/node/db/PadManager.js:119:7)
at /home/tuttle/Projects/etherpad-lite/src/node_modules/ueberDB/CloneAndAtomicLayer.js:95:17
at /home/tuttle/Projects/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:183:7
at [object Object].get (/home/tuttle/Projects/etherpad-lite/src/node_modules/ueberDB/dirty_db.js:48:3)

[marcelklehr]

If you're indeed using api version v1, please use the latest version --
have a look at the docs...

[JohnMcLear]

Any update on this?

[Mic92]

I can confirm this bug with v1.2.7.

[JohnMcLear]

I'm due to document setHTML tonight, feel free to document it and issue a PR!

[dooug]

I am also getting this bug. I tried both the master branch and the develop branch.

[JohnMcLear]

Working on this now.

[JohnMcLear]

#1514 -- Will be working on this PR next 15 mins polishing it

[JohnMcLear]

People who care about this issue please

git checkout dont-die-on-bad-html

restart etherpad then try the call. Let me know if it works okay.

Tested okay my end. Doing docs now.

[dooug]

Thanks for working on this!

I tested the dont-die-on-bad-html branch. Any setHTML() API call no longer crashes with an error. However, the pad content is always set to be blank.

[Miserlou]

Douug - what HTML are you testing with? I have found that this call is
*extremely
*fickle and even valid HTML will crash it in some cases.

On Wed, Feb 13, 2013 at 10:25 AM, Dooug notifications@github.com wrote:

I tested the dont-die-on-bad-html branch. Any setHTML() API call no longer
crashes with an error. However, the pad content is always set to be blank.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1449#issuecomment-13509102.

[Miserlou]

Sorry, not crash, just produce the scenario you're describing.

On Wed, Feb 13, 2013 at 10:29 AM, Rich Jones rich@anomos.info wrote:

Douug - what HTML are you testing with? I have found that this call is *extremely
*fickle and even valid HTML will crash it in some cases.

On Wed, Feb 13, 2013 at 10:25 AM, Dooug notifications@github.com wrote:

I tested the dont-die-on-bad-html branch. Any setHTML() API call no
longer crashes with an error. However, the pad content is always set to be
blank.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1449#issuecomment-13509102.

[JohnMcLear]

@Miserlou please provide HTML that fails.

[dooug]

I tried with simple html tags, like <h1>, and without any html tags. Nothing I have tried with setHTML() has insert content into the pad.

On invalid HTML, i see the warning in the log: [WARN] ImportHtml - HTML was not properly formed

[Miserlou]

You must include html and /html tags at the begining and end for it to work. I also found that I had to remove all spaces and newline characters, but that might have been voodoo.

[dooug]

@Miserlou, thanks for the suggestion. Can you provide a example that works for you?