Line number linking doesn’t work

[dertuxmalwieder]

Describe the bug
I enabled line numbers in the pad settings and clicking a line number links to the anchor (e.g.) #L156. However, opening the pad with the #L156 anchor does not scroll down to line 156.

Server (please complete the following information):

• Etherpad version: 1.8.12 (from Git)
• OS: FreeBSD 12
• Node.js version (node --version): v15.11.0
• npm version (npm --version): 6.14.8

Desktop (please complete the following information):

• OS: macOS Big Sur
• Browser: Safari
• Version: 14.0.3

[JohnMcLear]

This is tested in CI and was working last time I looked. What do the ci tests show for this functionality? Do you get a pass if you visit /tests/frontend ?

[dertuxmalwieder]

No, I don’t.

It’s probably this one:

scrollTo.js
scrolls to line
Scrolls down to Line 4 ‣
Error: Timeout of 100ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
(https://<DOMAIN>.de/tests/frontend/lib/mocha.js:5526)
doesnt break on weird hash input

[JohnMcLear]

That's the one thanks. When you clone from git are you getting develop branch? Can you tell us your git sha?

[dertuxmalwieder]

Yes, it’s develop. I’m running 5c9514f.

[JohnMcLear]

Oh wow thanks for quick feedback.. so it passes in CI, is frontend code yet you have bugs... Is this a public instance??

[dertuxmalwieder]

It is. It’s piraten-bs-pad.de (officially provided by the local chapter of the Pirate Party).

[JohnMcLear]

Okay thanks and can you replicate this issue on https://dark.etherpad.com ?

[dertuxmalwieder]

Yup:
https://dark.etherpad.com/p/Test#L102

[JohnMcLear]

Seems to be confirmed... So test is failing and logic where logic was working... Test needs fixing asap to show failure.

[JohnMcLear]

Thanks btw... This is awkward one so a good catch

[dertuxmalwieder]

Happy to help! :-) Please keep me updated when I can test that!

[webzwo0i]

This should be fixed in #4954
I saw @rhansen did another PR with the main patch from 4954. Will check his PR today and merge, but in the mean time if you want to test any of the two mentioned PRs it would be awesome.

So the problem is why the test is passing (if that's still true)

[rhansen]

Fixed by #4960