fix the url encoding in timeslider & return to pad link#136
Closed
hikinggrass wants to merge 3 commits intoether:masterfrom
Closed
fix the url encoding in timeslider & return to pad link#136hikinggrass wants to merge 3 commits intoether:masterfrom
hikinggrass wants to merge 3 commits intoether:masterfrom
Conversation
… this breaks if you reload the page. better: use a substring of document.location.href
…rer with a pad-url is given (/p/*) use this referrer for the Return to pad link, if not use a substring of document.location
Contributor
There was a problem hiding this comment.
better use decodeURIComponent(padID)
see my patch Wikinaut@5ea8dd6
Contributor
There was a problem hiding this comment.
@Pita: in my version: yes. I recommend to use decodeURIComponent instead of unescape (in pad2.js and in timeslider.html)
See http://xkr.us/articles/javascript/encode-compare/ and other webpages.
I also changed the order of padname and "Etherpad lite" string in HTML page titles, see Wikinaut@a671140 I like to have the specific padname beginning the page titles and browser tabs such as "Mypad | Etherpad lite", instead of the non-specific "Etherpad lite | Mypad".
Contributor
|
I think we can close this or? Should be fixed with @wikinauts commit |
Contributor
|
I cherry picked your last commit hikinggrass@ae73b11 thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the broken url ecoding in the timeslider if a pad with spaces in its name is opened,
The second commit fixes the behavior of the "Return to pad" link if the page is reloaded. This was broken because after a reload document.referrer points to timeslider, not to the original pad.