Added a better way of detecting when a url does not have a protocol spec...#1963
Merged
marcelklehr merged 1 commit intoether:developfrom Oct 28, 2013
Merged
Conversation
Contributor
|
So what happens to things like |
Contributor
|
Ah, no. I think it's alright. |
Contributor
Author
|
I could try do it as a regular expression, something like what is mentioned here: Should I rewrite it? |
marcelklehr
added a commit
that referenced
this pull request
Oct 28, 2013
Fix #1776 - All links regardless of protocol translate to http:// links
Contributor
|
works. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for Issue #1776 - All links regardless of protocol translate to http:// links
When a protocol is not specified for a link, it is assumed that the protocol is http.
The issue was that the detection for when a protocol is not specified only checked for http. I've updated this to have broader detection.