Server doesn't check bounds on CHANGESET_REQ arguments#2038
Merged
JohnMcLear merged 1 commit intoether:developfrom Dec 17, 2013
Merged
Conversation
The server wasn't properly checking that the changesets it needed to return for changeset_requests actually existed.
JohnMcLear
added a commit
that referenced
this pull request
Dec 17, 2013
…_req_bounds Server doesn't check bounds on CHANGESET_REQ arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server wasn't properly checking that the changesets it needed to return for changeset_requests actually existed, causing it to occasionally crash. See issue #477.
This fixes it.