Skip to content

add the ability to set global password with http basic auth#255

Merged
Pita merged 2 commits intoether:masterfrom
alx:issue241
Dec 4, 2011
Merged

add the ability to set global password with http basic auth#255
Pita merged 2 commits intoether:masterfrom
alx:issue241

Conversation

@alx
Copy link
Copy Markdown
Contributor

@alx alx commented Dec 1, 2011

Related to issue #241

@alx
Copy link
Copy Markdown
Contributor Author

alx commented Dec 1, 2011

duplicate #241

@alx alx closed this Dec 1, 2011
@alx alx reopened this Dec 1, 2011
@alx
Copy link
Copy Markdown
Contributor Author

alx commented Dec 1, 2011

sorry, I thought it was a duplicated issue, still learning github interface.

Comment thread node/server.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a timeout of 5 seconds?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, new to node.js and express, found the example on : http://node-js.ru/3-writing-express-middleware

would it need to be removed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea was to slow down a brute force attack. I reduced it to 1s now

@Pita Pita merged commit a520c1e into ether:master Dec 4, 2011
@Pita
Copy link
Copy Markdown
Contributor

Pita commented Dec 4, 2011

thats merged, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants