add test for wrong clientHeight#4965
Merged
JohnMcLear merged 1 commit intodevelopfrom Mar 20, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small test case for inner height regression, ie clientHeight should be identical to scrollHeight on pads with few lines, but should be less than scrollHeight on pads with lots of lines.
This is useful as a guard against a regression where scrolling, line number links (and maybe other things that depend on getInnerHeight or
clientHeight) stopped working. The solution to this problem was cb9f6d6See #4954 (comment) for details why this test should be extended to check if the editor "has grown" when the number of pad lines reach below the viewport area and why I struggled implementing it.