Skip to content

add docker dev setup#6155

Merged
SamTV12345 merged 12 commits intoether:developfrom
JannikStreek:fix-docker-setup
Feb 16, 2024
Merged

add docker dev setup#6155
SamTV12345 merged 12 commits intoether:developfrom
JannikStreek:fix-docker-setup

Conversation

@JannikStreek
Copy link
Copy Markdown
Contributor

@JannikStreek JannikStreek commented Feb 15, 2024

This pull-request features the following:

  • Added development setup for docker. A target can be used to select between development and production
  • Added a docker compose file for easier setup (also possible to use this for production)
  • Integrated pnpm into docker
  • For security purposes made the COPY in production more precise; e.g. copy dedicated git files separately instead of copying everything, which might result in security vulnerabilities when accidentally including sensitive files.

closes #6156, #5169

@SamTV12345
Copy link
Copy Markdown
Member

Hi Jannik,

thanks for the pull request. This looks awesome and will definetely help getting started with etherpad. I am currently wondering why the image size increased that much:

Before:
image

After building with docker build --target production -t etherpad/etherpad:develop .:
image

@JannikStreek
Copy link
Copy Markdown
Contributor Author

@SamTV12345 thanks for the feedback, I will double check where the size is coming from.

@JannikStreek
Copy link
Copy Markdown
Contributor Author

JannikStreek commented Feb 16, 2024

@SamTV12345 I think I found the reason, can you check again? RUN chmod -R g=u . increased the image size by 50 mbs...I commented it for now, as it was before. I also added a readme section to explain the compose setup.

Copy link
Copy Markdown
Member

@SamTV12345 SamTV12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this pull request.

@SamTV12345 SamTV12345 merged commit 03c8518 into ether:develop Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docker development setup

2 participants