Adapted docker.yml#6933
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/docker.yml:132
- Uncomment or remove the conditional check if it is intended to control the execution of the tag update step; otherwise, this step will run on all events, which may lead to unintended behavior.
#if: github.event == 'push' && github.ref == 'refs/heads/develop'
| sed -i 's/tag: ".*"/tag: "${{ steps.meta.outputs.sha }}"/' values-dev.yaml | ||
| - name: Commit and push changes | ||
| path: ether-charts | ||
| #if: github.event == 'push' && github.ref == 'refs/heads/develop' |
There was a problem hiding this comment.
Ensure that the commit and push step is correctly gated by a conditional; if the if-statement is meant to limit execution to the develop branch, it should be activated to avoid accidental commits on other branches.
Suggested change
| #if: github.event == 'push' && github.ref == 'refs/heads/develop' | |
| if: github.event == 'push' && github.ref == 'refs/heads/develop' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.