Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/node/hooks/express/openapi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -612,17 +612,30 @@ exports.expressPreSession = async (hookName:string, {app}:any) => {

// read form data if method was POST
let formData:MapArrayType<any> = {};
if (c.request.method === 'post') {
const form = new IncomingForm();
formData = (await form.parse(req))[0];
for (const k of Object.keys(formData)) {
if (formData[k] instanceof Array) {
formData[k] = formData[k][0];
if ((c.request.method || '').toLowerCase() === 'post') {
// If express.json() already parsed the body (application/json),
// use req.body directly. Formidable would hang waiting for an
// already-consumed stream, causing the request to time out.
if (req.body && typeof req.body === 'object') {
formData = req.body;
} else {
const form = new IncomingForm();
formData = (await form.parse(req))[0];
Comment thread
qodo-free-for-open-source-projects[bot] marked this conversation as resolved.
for (const k of Object.keys(formData)) {
if (formData[k] instanceof Array) {
formData[k] = formData[k][0];
}
}
}
}

const fields = Object.assign({}, headers, params, query, formData);
// Merge parameters with clear precedence: body > query > path params.
// Only pass the authorization header explicitly — don't merge all headers
// into fields to prevent parameter pollution.
const fields = Object.assign({}, params, query, formData);
if (headers.authorization) {
fields.authorization = fields.authorization || headers.authorization;
}
if (logger.isDebugEnabled()) {
logger.debug(`REQUEST, v${version}:${funcName}, ${JSON.stringify(fields)}`);
}
Expand Down
Loading