Skip to content

fix(userlist): stop username input overlapping Log out button (#7593) #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnMcLear wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −0
Open

fix(userlist): stop username input overlapping Log out button (#7593) #7597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/static/css/pad/popup_users.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@

#myusernameform {
margin-left: 10px;
/* Constrain the username input so the adjacent Log out button does not
get pushed off the Users popup — previously the input expanded to its
natural default width and overlapped the button. Fixes #7593. */
width: 75px;
Comment on lines +61 to +64
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for #7593 📘 Rule violation ☼ Reliability

This PR is a bug fix (Fixes #7593) but it adds no automated regression test that would fail if the
CSS fix is reverted. Without a test, the Log out button overlap/clipping issue can easily regress
unnoticed.
Agent Prompt 
## Issue description
The PR fixes a UI regression (username input overlapping the Log out button) but does not add an automated regression test to prevent the bug from reappearing.

## Issue Context
The CSS change is marked as a bug fix (`Fixes #7593`). Per compliance, a regression test should fail if the fix is reverted and pass with the fix.

## Fix Focus Areas
- src/static/css/pad/popup_users.css[61-77]
- src/tests/frontend/specs/helper.js[1-120]
- src/tests/frontend/specs/[add new spec file to cover Users popup layout][1-200]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

}
Comment on lines +61 to 65
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Skin min-width defeats fix 🐞 Bug ≡ Correctness

In the default Colibris skin, input#myusernameedit has min-width: 110px, so it can still overflow
the newly constrained 75px #myusernameform container, undermining the intent to prevent overlap with
adjacent controls (e.g., Log out). This can cause the same layout overflow in the default Etherpad
skin configuration.
Agent Prompt 
### Issue description
The base CSS now constrains `#myusernameform` to `75px`, but the default Colibris skin sets `input#myusernameedit { min-width: 110px; }`, which can force the input wider than its container and reintroduce overflow/overlap.

### Issue Context
Etherpad loads `../static/css/pad.css` and then `../static/skins/${skinName}/pad.css`, and `skinName` defaults to `colibris`. The Colibris users component CSS currently enforces a minimum input width.

### Fix Focus Areas
- src/static/skins/colibris/src/components/users.css[28-40]

### Suggested fix
In Colibris `users.css`, adjust the username input rule to allow shrinking within the constrained container (e.g., remove/reduce `min-width`, or set `min-width: 0; max-width: 100%; box-sizing: border-box;`), aligning it with the intent of the base fix.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

input#myusernameedit {
height: 26px;
Expand All @@ -66,6 +70,11 @@ input#myusernameedit {
border: 1px solid #ccc;
background-color: transparent;
margin: 0;
/* Keep the input inside its 75px container (border + padding included).
Without these the text field renders wider than the container on its
natural content width and overlaps the Log out button. */
width: 100%;
box-sizing: border-box;
}
input#myusernameedit:not(.editable) {
color: grey;
Expand Down
Loading