chore: added release notes for 2.7.2#7604
Merged
SamTV12345 merged 2 commits intodevelopfrom Apr 26, 2026
Merged
Conversation
Review Summary by QodoMigrate CI/CD workflows from gnpm to pnpm and update to v10.33.2
WalkthroughsDescription• Replaced deprecated gnpm package manager with native pnpm across all CI/CD workflows • Simplified Node.js version matrix from semantic ranges to major version numbers (20, 22, 24) • Restructured caching strategy to separately cache pnpm store and node_modules directories • Updated pnpm version to 10.33.2 and replaced custom gnpm setup action with official pnpm action • Added release notes for version 2.7.2 with accessibility and feature improvements Diagramflowchart LR
gnpm["gnpm package manager<br/>v0.0.12"]
pnpm["pnpm package manager<br/>v10.33.2"]
oldCache["Single gnpm cache<br/>with multiple paths"]
newCache["Separate pnpm store<br/>and node_modules caches"]
nodeVersions["Node version ranges<br/>>=20.0.0, >=22.0.0, etc"]
nodeVersionsNew["Node major versions<br/>20, 22, 24"]
gnpm -->|"Replace with"| pnpm
oldCache -->|"Restructure to"| newCache
nodeVersions -->|"Simplify to"| nodeVersionsNew
File Changes1. .github/workflows/backend-tests.yml
|
Code Review by Qodo
1. Plugin cache key mismatch
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
149
to
153
| name: Install Etherpad plugins | ||
| run: > | ||
| gnpm install --workspace-root | ||
| pnpm add -w | ||
| ep_align | ||
| ep_author_hover |
There was a problem hiding this comment.
1. Plugin cache key mismatch 🐞 Bug ☼ Reliability
Workflows install plugins via pnpm add -w (changing the runtime dependency set) but the restored/saved node_modules cache key is still derived only from the pre-step pnpm-lock.yaml hash, so with-plugins jobs can save a cache that later restores into jobs that were intended to run without plugins. Etherpad enumerates installed plugins on startup (and will migrate plugins found in node_modules), so restoring a cache with unexpected plugin packages can change test behavior and cause flakiness.
Agent Prompt
### Issue description
CI caches `node_modules` using a key that does not encode the plugin set, but plugin jobs change dependencies at runtime via `pnpm add -w`. This can cause caches produced by with-plugins jobs to be restored in jobs intended to run without plugins, changing which plugins Etherpad loads during tests.
### Issue Context
Etherpad migrates plugins from `node_modules` and logs installed plugins at startup, so unexpected plugin packages present in `node_modules` can affect test execution.
### Fix Focus Areas
- Replace `pnpm add -w ...` with the repo-supported plugin installer (does not mutate workspace deps/lockfile in the same way):
- .github/workflows/backend-tests.yml[149-163]
- .github/workflows/load-test.yml[104-118]
- .github/workflows/frontend-admin-tests.yml[85-105] (if plugins are added similarly elsewhere)
- And/or ensure caches cannot be shared between with-plugins and without-plugins jobs by making cache keys job-variant-specific:
- .github/workflows/backend-tests.yml[43-56]
- .github/workflows/backend-tests.yml[113-126]
(Option examples: use `pnpm run install-plugins <list>`; or add a `-withplugins` suffix to cache keys for plugin jobs; or drop `node_modules` caching and rely on pnpm store caching.)
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
SamTV12345
changed the title
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.