Skip to content

test: tag two chat-toggle pad_settings specs with @feature:chat#7655

Merged
JohnMcLear merged 1 commit intodevelopfrom
fix/tag-pad-settings-chat-tests
May 2, 2026
Merged

test: tag two chat-toggle pad_settings specs with @feature:chat#7655
JohnMcLear merged 1 commit intodevelopfrom
fix/tag-pad-settings-chat-tests

Conversation

@JohnMcLear
Copy link
Copy Markdown
Member

Surfaced by ep_disable_chat#75 (the disables contract PoC). Pass 1 of the disables-aware runner failed on:

  • pad_settings.spec.ts:146 — disabling chat suppresses chat gritter notifications
  • pad_settings.spec.ts:167 — disabling chat disables and visually greys the dependent chat toggles

Both click label[for="options-disablechat"] — the "Disable chat" toggle that ep_disable_chat removes from the UI by design. Tagging them with @feature:chat lets them be excluded from pass 1 (regression — they SHOULDN'T run when chat is removed) and counted in pass 2 (honesty — they should fail).

Without these tags, ep_disable_chat (and any future chat-removing plugin) cannot ship green CI even with a correct disables declaration. Pure follow-up to the upstream tagging in #7648.

🤖 Generated with Claude Code

Surfaced by ep_disable_chat#75 — the disables-aware test runner ran
pass 1 (regression) and these two tests failed because they click
label[for="options-disablechat"], which ep_disable_chat hides as
intended. Tagging them brings them into pass 2 (honesty) where
they're expected to fail under the plugin, instead of pass 1 where
they shouldn't run.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

Review Summary by Qodo

Tag two chat-toggle pad_settings specs with @feature:chat

🧪 Tests

Grey Divider

Walkthroughs

Description
• Tag two pad_settings chat tests with @feature:chat
• Enables disables-aware test runner to properly categorize tests
• Tests click chat toggle removed by ep_disable_chat plugin
• Allows tests to run in pass 2 (honesty) instead of pass 1 (regression)
Diagram
flowchart LR
  A["pad_settings.spec.ts tests"] -- "add @feature:chat tag" --> B["Categorized for disables-aware runner"]
  B -- "pass 1: regression" --> C["Excluded when chat disabled"]
  B -- "pass 2: honesty" --> D["Expected to fail with plugin"]
Loading

Grey Divider

File Changes

1. src/tests/frontend-new/specs/pad_settings.spec.ts 🧪 Tests +6/-2

Add @feature:chat tags to two chat tests

• Added tag: '@feature:chat' to test at line 146 (disabling chat suppresses chat gritter
 notifications)
• Added tag: '@feature:chat' to test at line 167 (disabling chat disables and visually greys the
 dependent chat toggles)
• Both tests interact with chat toggle that ep_disable_chat plugin removes from UI
• Tags enable proper test categorization in disables-aware test runner

src/tests/frontend-new/specs/pad_settings.spec.ts


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

qodo-free-for-open-source-projects Bot commented May 2, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@JohnMcLear JohnMcLear merged commit 983aec5 into develop May 2, 2026
42 checks passed
@JohnMcLear JohnMcLear deleted the fix/tag-pad-settings-chat-tests branch May 2, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant