test: tag two chat-toggle pad_settings specs with @feature:chat#7655
Merged
JohnMcLear merged 1 commit intodevelopfrom May 2, 2026
Merged
test: tag two chat-toggle pad_settings specs with @feature:chat#7655JohnMcLear merged 1 commit intodevelopfrom
JohnMcLear merged 1 commit intodevelopfrom
Conversation
Surfaced by ep_disable_chat#75 — the disables-aware test runner ran pass 1 (regression) and these two tests failed because they click label[for="options-disablechat"], which ep_disable_chat hides as intended. Tagging them brings them into pass 2 (honesty) where they're expected to fail under the plugin, instead of pass 1 where they shouldn't run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Review Summary by QodoTag two chat-toggle pad_settings specs with @feature:chat
WalkthroughsDescription• Tag two pad_settings chat tests with @feature:chat • Enables disables-aware test runner to properly categorize tests • Tests click chat toggle removed by ep_disable_chat plugin • Allows tests to run in pass 2 (honesty) instead of pass 1 (regression) Diagramflowchart LR
A["pad_settings.spec.ts tests"] -- "add @feature:chat tag" --> B["Categorized for disables-aware runner"]
B -- "pass 1: regression" --> C["Excluded when chat disabled"]
B -- "pass 2: honesty" --> D["Expected to fail with plugin"]
File Changes1. src/tests/frontend-new/specs/pad_settings.spec.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by ep_disable_chat#75 (the disables contract PoC). Pass 1 of the disables-aware runner failed on:
pad_settings.spec.ts:146 — disabling chat suppresses chat gritter notificationspad_settings.spec.ts:167 — disabling chat disables and visually greys the dependent chat togglesBoth click
label[for="options-disablechat"]— the "Disable chat" toggle that ep_disable_chat removes from the UI by design. Tagging them with@feature:chatlets them be excluded from pass 1 (regression — they SHOULDN'T run when chat is removed) and counted in pass 2 (honesty — they should fail).Without these tags, ep_disable_chat (and any future chat-removing plugin) cannot ship green CI even with a correct
disablesdeclaration. Pure follow-up to the upstream tagging in #7648.🤖 Generated with Claude Code