fix(admin): restore SearchField + sorting modules used by AuthorPage#7746
Merged
JohnMcLear merged 2 commits intoMay 15, 2026
Merged
Conversation
PR ether#7736 ("replace hardcoded German strings with i18n keys") deleted admin/src/components/SearchField.tsx and admin/src/utils/sorting.ts as "orphan modules (no longer imported anywhere after ether#7716)". At that point, the GDPR admin AuthorPage (PR ether#7667) had not yet landed on develop. When ether#7667 merged afterwards, the new admin/src/pages/AuthorPage.tsx brought back imports of SearchField and determineSorting — but the files were already gone, leaving develop with broken admin imports. This breaks `pnpm --filter admin run build-copy` on every CI job that builds the admin UI: src/pages/AuthorPage.tsx(6,27): error TS2307: Cannot find module '../components/SearchField.tsx' or its corresponding type declarations. src/pages/AuthorPage.tsx(9,32): error TS2307: Cannot find module '../utils/sorting.ts' or its corresponding type declarations. src/pages/AuthorPage.tsx(207,29): error TS7006: Parameter 'v' implicitly has an 'any' type. Backend tests, Frontend admin tests, Docker (build-test, build-test-local-plugin, build-test-db-drivers), rate limit, and Upgrade from latest release all fail at the admin build step on develop. Restore both files verbatim from before the deletion (commit ff7c4d5^). With them back in place AuthorPage.tsx's existing imports resolve, the implicit-any on the SearchField onChange callback goes away (typed via SearchFieldProps), and `pnpm --filter admin run build-copy` succeeds. This is the minimal, surgical fix; whether SearchField / determineSorting should ultimately be inlined into AuthorPage is a separate cleanup. Test plan: - cd admin && pnpm exec tsc --noEmit → no errors - cd admin && pnpm exec tsc && pnpm exec vite build → built in 545ms Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Review Summary by QodoRestore SearchField and sorting modules for AuthorPage
WalkthroughsDescription• Restores deleted SearchField and sorting modules • Fixes broken admin build imports in AuthorPage • Resolves TypeScript compilation errors TS2307 and TS7006 • Unblocks CI pipeline failures across multiple jobs Diagramflowchart LR
A["PR #7736 deleted<br/>SearchField + sorting"] --> B["PR #7667 merged<br/>with AuthorPage imports"]
B --> C["Broken imports<br/>TS2307 errors"]
C --> D["CI failures:<br/>admin build"]
D --> E["Restore files<br/>from ff7c4d531"]
E --> F["AuthorPage imports<br/>resolve successfully"]
File Changes1. admin/src/utils/sorting.ts
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
…rPage imports them PR ether#7736 added a lint assertion that admin/src/components/SearchField.tsx and admin/src/utils/sorting.ts must NOT exist, on the assumption they were dead code after ether#7716. They aren't — the GDPR AuthorPage (ether#7667) imports both. The previous commit restored the files; this commit flips the assertion so the test: - verifies both files exist - verifies admin/src/pages/AuthorPage.tsx still imports them If a future cleanup wants to delete these modules, the test now forces the author to also delete or refactor the AuthorPage consumption first, preventing a repeat of the merge-order accident that produced this bug. Test plan: - cd src && pnpm exec vitest run tests/backend-new/specs/admin-i18n-source-lint.test.ts → 14 passed (14) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin/src/components/SearchField.tsxandadmin/src/utils/sorting.ts, which fix(admin): replace hardcoded German strings with i18n keys (#7735) #7736 deleted as "orphan modules" before feat(gdpr): admin UI for author erasure (follow-up to #7550) #7667 (GDPR admin AuthorPage) merged and reintroduced the imports.TS2307: Cannot find module '../components/SearchField.tsx'(and a knock-onTS7006implicit-any on the SearchField onChange callback), which is what's currently breaking Backend tests, Frontend admin tests, Docker (build-test / build-test-local-plugin / build-test-db-drivers), rate limit, and Upgrade from latest release on develop.Why this happened
SearchField/determineSorting.admin/src/pages/AuthorPage.tsx, which still importsSearchFieldanddetermineSorting.Develop now has an
AuthorPage.tsxwhose imports point at deleted files. Every CI job that runspnpm --filter admin run build-copy(directly or transitively through Docker / Backend tests / Frontend admin tests) fails at thetscstep.The fix
Restore both files verbatim from
ff7c4d531^. This is the minimum change needed to make develop's admin build pass again. Inlining the two helpers intoAuthorPage.tsx(or deleting them again together with their consumers) can be done as follow-up cleanup.Test plan
cd admin && pnpm exec tsc --noEmit— no errorscd admin && pnpm exec tsc && pnpm exec vite build— built in 545ms; admin bundle written tosrc/templates/admin🤖 Generated with Claude Code