Skip to content

New features + some bugfixes#85

Closed
0ip wants to merge 23 commits into
ether:masterfrom
0ip:master
Closed

New features + some bugfixes#85
0ip wants to merge 23 commits into
ether:masterfrom
0ip:master

Conversation

@0ip
Copy link
Copy Markdown
Member

@0ip 0ip commented Aug 16, 2011

  • Added QR code support for readonly links
  • Reworked the start page (brighter, added top bar, font on Windows sharper), fixed some bugs and compressed the js
  • Applied new color scheme for the editbar
  • Improved the usability of the editbar buttons
  • Icon backgrounds are now transparent

All changes are very well tested on every browser and yes, despite tons of bugs, I think UI improvements are still important. :)

@Pita
Copy link
Copy Markdown
Contributor

Pita commented Aug 16, 2011

@johnyma22 should decide about that

@JohnMcLear
Copy link
Copy Markdown
Member

Very first thing I looked at looks like the javascript padding is now 4 spaces when it should be 2, this will upset Pita. I will look at the other commits later today.

@JohnMcLear
Copy link
Copy Markdown
Member

In the future please don't put 20 commits into one pull request. There should be a seperate pull request for each new features and for bugfixes (preferably one for each with the corresponding issue #)

@0ip
Copy link
Copy Markdown
Member Author

0ip commented Aug 16, 2011

Okay

@JohnMcLear
Copy link
Copy Markdown
Member

f8c5db6 - compressed js, redesigned custom pad form and added top bar -- We're not pulling this because it doesn't conform to our spacing standards.

e433926 - too many changes to okay, please only modify the items you have changed and resubmit

Please don't remove lines then re-add if you only make a minor change.

Please ensure JS and CSS has the correct indent/spacing as conforms with the way the rest of the project looks.

Please ensure all changes are properly documented, an example of a bad description is: "Edited static/pad.html via GitHub"

Once the CSS is updated and the titles are updated we can look at pulling. Issue a new pull request for that. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants