chore: apply oxfmt across the tree (1/3 of #991)#992
Open
SamTV12345 wants to merge 4 commits into
Open
Conversation
Side-effect of `pnpm run format` during Win 4 implementation. No logic changes — quote style, spacing, trailing-comma normalization, and the standard oxfmt rule set applied repo-wide. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
oxfmt reformats get()'s r.table().get().run() into a multi-line chain, which moves the existing // @ts-ignore off the .run(this.connection, ...) line and re-surfaces TS2769 (Connection | null). Assert non-null to keep the reformatted code type-clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Review Summary by QodoApply oxfmt formatting across the repository (Part 1/3)
WalkthroughsDescription• Applied oxfmt formatting across ~60 files in the repository (drivers, tests, configs, documentation, and CI files) • Standardized code style: converted single quotes to double quotes, normalized spacing around braces and type annotations, adjusted indentation from 4 to 2 spaces • Reformatted import statements, function signatures, object literals, and multi-line expressions for consistency • Removed two stray console.log statements from test/postgres/test.postgresql.spec.ts • Added non-null assertion this.connection! in databases/rethink_db.ts to fix TypeScript error (TS2769) caused by oxfmt reformatting moving the // @ts-ignore comment off the .run() line • Reorganized package.json field order to follow standard npm structure • Updated markdown files (README, CHANGELOG, CONTRIBUTING) with consistent bullet point formatting • Verified with tsc --noEmit and vitest run test/mock test/memory (173 passing tests) Diagramflowchart LR
A["Source Files<br/>Drivers, Tests, Lib"] -->|"oxfmt formatting"| B["Standardized Code<br/>Quotes, Spacing, Indentation"]
C["Config Files<br/>JSON, YAML, TS"] -->|"oxfmt formatting"| B
D["Documentation<br/>MD Files"] -->|"oxfmt formatting"| B
B -->|"Type Fix"| E["rethink_db.ts<br/>Add Non-null Assertion"]
B -->|"Cleanup"| F["Remove console.log<br/>from postgres test"]
E --> G["Ready for Merge<br/>Logic-only diffs next"]
F --> G
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: apply oxfmt across the tree
Part 1 of 3 from splitting #991. Pure formatting / mechanical change — no behavioral or API changes.
Runs
oxfmtover all tracked source, test, config, and docs files so the rest of the split (and future PRs) review as logic-only diffs. Also removes two strayconsole.logcalls fromtest/postgres/test.postgresql.spec.ts.What's in here
oxfmtreformatting of ~60 files (drivers, tests, configs, README/CHANGELOG/CONTRIBUTING, tsconfig, CI yml, etc.).console.logstatements in the postgres test.databases/rethink_db.ts: oxfmt breaksr.table().get().run()inget()into a multi-line chain, which moves the existing// @ts-ignoreoff the.run(this.connection, …)line and re-surfacesTS2769 (Connection | null). Athis.connection!assertion keeps the reformatted code type-clean. This is fallout from the reformat, so it lives here rather than in the driver PR.Why split this out
This is the noisy, mechanical half of #991. Landing it on its own keeps the two functional PRs (cache and drivers) as readable logic diffs.
Verification
tsc --noEmitpasses.vitest run test/mock test/memory→ 173 passing (no DB required).Merge order
Merge this first. It touches
mongodb_db.ts/postgres_db.ts(shared with the drivers PR) andtest_tojson.spec.ts(shared with the cache PR), so the other two should be rebased on top once this lands.🤖 Generated with Claude Code