Skip to content

chore: apply oxfmt across the tree (1/3 of #991)#992

Open
SamTV12345 wants to merge 4 commits into
mainfrom
chore/oxfmt-formatting
Open

chore: apply oxfmt across the tree (1/3 of #991)#992
SamTV12345 wants to merge 4 commits into
mainfrom
chore/oxfmt-formatting

Conversation

@SamTV12345
Copy link
Copy Markdown
Member

chore: apply oxfmt across the tree

Part 1 of 3 from splitting #991. Pure formatting / mechanical change — no behavioral or API changes.

Runs oxfmt over all tracked source, test, config, and docs files so the rest of the split (and future PRs) review as logic-only diffs. Also removes two stray console.log calls from test/postgres/test.postgresql.spec.ts.

What's in here

  • oxfmt reformatting of ~60 files (drivers, tests, configs, README/CHANGELOG/CONTRIBUTING, tsconfig, CI yml, etc.).
  • Removal of two leftover console.log statements in the postgres test.
  • One required one-line fix in databases/rethink_db.ts: oxfmt breaks r.table().get().run() in get() into a multi-line chain, which moves the existing // @ts-ignore off the .run(this.connection, …) line and re-surfaces TS2769 (Connection | null). A this.connection! assertion keeps the reformatted code type-clean. This is fallout from the reformat, so it lives here rather than in the driver PR.

Why split this out

This is the noisy, mechanical half of #991. Landing it on its own keeps the two functional PRs (cache and drivers) as readable logic diffs.

Verification

  • tsc --noEmit passes.
  • vitest run test/mock test/memory → 173 passing (no DB required).

Merge order

Merge this first. It touches mongodb_db.ts / postgres_db.ts (shared with the drivers PR) and test_tojson.spec.ts (shared with the cache PR), so the other two should be rebased on top once this lands.

Note: oxfmt --check reports diffs locally because the repo has no oxfmt config checked in (it falls back to defaults / a different version). This is pre-existing — the original #991 branch behaves identically — and is out of scope for this PR.

🤖 Generated with Claude Code

SamTV12345 and others added 4 commits May 28, 2026 22:42
Side-effect of `pnpm run format` during Win 4 implementation. No
logic changes — quote style, spacing, trailing-comma normalization,
and the standard oxfmt rule set applied repo-wide.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
oxfmt reformats get()'s r.table().get().run() into a multi-line chain,
which moves the existing // @ts-ignore off the .run(this.connection, ...)
line and re-surfaces TS2769 (Connection | null). Assert non-null to keep
the reformatted code type-clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

Review Summary by Qodo

Apply oxfmt formatting across the repository (Part 1/3)

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Applied oxfmt formatting across ~60 files in the repository (drivers, tests, configs,
  documentation, and CI files)
• Standardized code style: converted single quotes to double quotes, normalized spacing around
  braces and type annotations, adjusted indentation from 4 to 2 spaces
• Reformatted import statements, function signatures, object literals, and multi-line expressions
  for consistency
• Removed two stray console.log statements from test/postgres/test.postgresql.spec.ts
• Added non-null assertion this.connection! in databases/rethink_db.ts to fix TypeScript error
  (TS2769) caused by oxfmt reformatting moving the // @ts-ignore comment off the .run() line
• Reorganized package.json field order to follow standard npm structure
• Updated markdown files (README, CHANGELOG, CONTRIBUTING) with consistent bullet point formatting
• Verified with tsc --noEmit and vitest run test/mock test/memory (173 passing tests)
Diagram
flowchart LR
  A["Source Files<br/>Drivers, Tests, Lib"] -->|"oxfmt formatting"| B["Standardized Code<br/>Quotes, Spacing, Indentation"]
  C["Config Files<br/>JSON, YAML, TS"] -->|"oxfmt formatting"| B
  D["Documentation<br/>MD Files"] -->|"oxfmt formatting"| B
  B -->|"Type Fix"| E["rethink_db.ts<br/>Add Non-null Assertion"]
  B -->|"Cleanup"| F["Remove console.log<br/>from postgres test"]
  E --> G["Ready for Merge<br/>Logic-only diffs next"]
  F --> G

Loading

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects
Copy link
Copy Markdown

qodo-free-for-open-source-projects Bot commented May 28, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@SamTV12345 SamTV12345 requested a review from JohnMcLear May 28, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants