Skip to content

Conversation

@sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Jan 27, 2025

small updates to the pectra notice page

@sbvegan sbvegan requested a review from a team as a code owner January 27, 2025 20:15
@netlify
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit cdb6a96
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6797ea58dbb4220008e11a5d
😎 Deploy Preview https://deploy-preview-1294--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2025

📝 Walkthrough

Walkthrough

The pull request updates the pectra-changes.mdx document with specific information regarding the Pectra upgrade. It replaces general statements about upgrade dates with precise proposed activation dates and times for Holesky L1 and Sepolia L1, now including exact UTC timestamps. The mention of the Pectra upgrade for Holocene L1 has been corrected to Holesky L1. Additionally, the expected release date for Ethereum L1 clients has been updated to indicate a release by February 3rd, 2025, and a reference to the last Ethereum All Core Devs call on January 23rd, 2025, has been added. New callouts for chain and node operators indicate that the software is currently being tested, with releases expected to be finalized by the end of the week (January 27th to 31st). The overall structure of the document remains unchanged.

Possibly related PRs

Suggested reviewers

  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
pages/builders/notices/pectra-changes.mdx (2)

48-50: Standardize date format in the release timeline

For consistency with other dates in the document, the date range should include the year and use the full month name.

Apply this change:

-    The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). 
+    The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to January 31st, 2025).

104-107: Consider consolidating duplicate release information

This callout contains identical information to the chain operators section. Consider referencing a single source of truth for release timelines to avoid maintenance overhead and potential inconsistencies.

If consolidation is not desired, at least standardize the date format:

-    The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). 
+    The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to January 31st, 2025).
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e466fb8 and 1529c27.

📒 Files selected for processing (1)
  • pages/builders/notices/pectra-changes.mdx (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/pectra-changes.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/builders/notices/pectra-changes.mdx (1)

Line range hint 1-120: Verify placeholders before release

The document contains several placeholders that need to be updated before release:

  • Multiple instances of vTBD for version numbers
  • Multiple instances of activation-timestamp

Please ensure these placeholders are replaced with actual values before publishing.

🧰 Tools
🪛 LanguageTool

[duplication] ~108-~108: Possible typo: you repeated a word.
Context: ...o 31st). * op-node at vTBD * op-geth at vTBD ### Verify Your Configuration...

(ENGLISH_WORD_REPEAT_RULE)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pages/builders/notices/pectra-changes.mdx (2)

48-50: Use consistent date formatting in the chain operator callout

The date format should be consistent with the rest of the document and include the year.

Apply this change:

-    The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). 
+    The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to 31st, 2025).

104-107: Standardize date formatting and consider reusing content

The date format should be consistent, and since this is identical to the chain operator callout, consider reusing the content to avoid duplication.

  1. Apply the same date format change:
-    The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). 
+    The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to 31st, 2025).
  1. Consider extracting this common callout into a reusable component to avoid duplication with the chain operator section.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1529c27 and cdb6a96.

📒 Files selected for processing (2)
  • pages/builders/notices/pectra-changes.mdx (3 hunks)
  • words.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • words.txt
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/pectra-changes.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/builders/notices/pectra-changes.mdx (1)

15-17: Improve clarity and consistency in the upgrade timeline section

The text requires improvements for clarity, consistency, and proper formatting:

  1. Use "All Core Devs Call" instead of "ACDC"
  2. Use full month names and days
  3. Include years in all dates
  4. Add missing articles
  5. Use proper capitalization for technical terms

Apply these changes:

-  This page will be updated continuously with information on upgrade runbooks and timelines as they come. This based on the last Ethereum ACDC on Jan 23rd 2025. These dates are subject to change based on how `devnet-6` goes. Ethereum L1 clients are expected to have a release out by Feb 3rd.
+  This page will be updated continuously with information on upgrade runbooks and timelines as they come. This is based on the last Ethereum All Core Devs Call on January 23rd, 2025. These dates are subject to change based on how `Devnet-6` goes. Ethereum L1 clients are expected to have a release by February 3rd, 2025.
-  *   The Pectra upgrade for Holesky L1 proposed activation is on **Wed, Feb 12 at 09:32:48 UTC (`1739352768`)**.
-  *   The Pectra upgrade for Sepolia L1 proposed activation is on **Wed, Feb 19 at 15:48:48 UTC (`1739980128`)**.
+  *   The Pectra upgrade for Holesky L1 proposed activation is on **Wednesday, February 12, 2025, at 09:32:48 UTC (`1739352768`)**.
+  *   The Pectra upgrade for Sepolia L1 proposed activation is on **Wednesday, February 19, 2025, at 15:48:48 UTC (`1739980128`)**.

@sbvegan sbvegan merged commit cd08d5d into main Jan 27, 2025
8 checks passed
@sbvegan sbvegan deleted the sb/pectra-notice-updates branch January 27, 2025 20:22
@coderabbitai coderabbitai bot mentioned this pull request Feb 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants