-
Couldn't load subscription status.
- Fork 274
adding small updates to notice page #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
pages/builders/notices/pectra-changes.mdx (2)
48-50: Standardize date format in the release timelineFor consistency with other dates in the document, the date range should include the year and use the full month name.
Apply this change:
- The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). + The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to January 31st, 2025).
104-107: Consider consolidating duplicate release informationThis callout contains identical information to the chain operators section. Consider referencing a single source of truth for release timelines to avoid maintenance overhead and potential inconsistencies.
If consolidation is not desired, at least standardize the date format:
- The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). + The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to January 31st, 2025).
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/builders/notices/pectra-changes.mdx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/pectra-changes.mdx (1)
Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/builders/notices/pectra-changes.mdx (1)
Line range hint
1-120: Verify placeholders before releaseThe document contains several placeholders that need to be updated before release:
- Multiple instances of
vTBDfor version numbers- Multiple instances of
activation-timestampPlease ensure these placeholders are replaced with actual values before publishing.
🧰 Tools
🪛 LanguageTool
[duplication] ~108-~108: Possible typo: you repeated a word.
Context: ...o 31st). *op-nodeatvTBD*op-gethatvTBD### Verify Your Configuration...(ENGLISH_WORD_REPEAT_RULE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pages/builders/notices/pectra-changes.mdx (2)
48-50: Use consistent date formatting in the chain operator calloutThe date format should be consistent with the rest of the document and include the year.
Apply this change:
- The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). + The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to 31st, 2025).
104-107: Standardize date formatting and consider reusing contentThe date format should be consistent, and since this is identical to the chain operator callout, consider reusing the content to avoid duplication.
- Apply the same date format change:
- The software is currently being tested and we expect the releases to be cut by the end of this week (Jan 27th to 31st). + The software is currently being tested and we expect the releases to be cut by the end of this week (January 27th to 31st, 2025).
- Consider extracting this common callout into a reusable component to avoid duplication with the chain operator section.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/builders/notices/pectra-changes.mdx(3 hunks)words.txt(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- words.txt
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/pectra-changes.mdx (1)
Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/builders/notices/pectra-changes.mdx (1)
15-17: Improve clarity and consistency in the upgrade timeline sectionThe text requires improvements for clarity, consistency, and proper formatting:
- Use "All Core Devs Call" instead of "ACDC"
- Use full month names and days
- Include years in all dates
- Add missing articles
- Use proper capitalization for technical terms
Apply these changes:
- This page will be updated continuously with information on upgrade runbooks and timelines as they come. This based on the last Ethereum ACDC on Jan 23rd 2025. These dates are subject to change based on how `devnet-6` goes. Ethereum L1 clients are expected to have a release out by Feb 3rd. + This page will be updated continuously with information on upgrade runbooks and timelines as they come. This is based on the last Ethereum All Core Devs Call on January 23rd, 2025. These dates are subject to change based on how `Devnet-6` goes. Ethereum L1 clients are expected to have a release by February 3rd, 2025. - * The Pectra upgrade for Holesky L1 proposed activation is on **Wed, Feb 12 at 09:32:48 UTC (`1739352768`)**. - * The Pectra upgrade for Sepolia L1 proposed activation is on **Wed, Feb 19 at 15:48:48 UTC (`1739980128`)**. + * The Pectra upgrade for Holesky L1 proposed activation is on **Wednesday, February 12, 2025, at 09:32:48 UTC (`1739352768`)**. + * The Pectra upgrade for Sepolia L1 proposed activation is on **Wednesday, February 19, 2025, at 15:48:48 UTC (`1739980128`)**.
small updates to the pectra notice page