-
Notifications
You must be signed in to change notification settings - Fork 807
Add SHIB to token list #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add SHIB to token list #1240
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Financial
More Details
| Attribute | Value |
|---|---|
| Data Classifier | Financial/Ethereum Address |
| Data Classifier ID | BUILTIN-388 |
Sampled Examples
| Key | Value |
|---|---|
| ethereum.address | 0x*D6...**cE (42 chars) |
Rule ID: BUILTIN-388
To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason
If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).
To get more details on how to remediate this issue using AI, reply to this conversation with #wiz remediate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#wiz_ignore Public contract address required for token listing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finding has been successfully ignored for these checks.
If you'd like to ignore this finding in all future scans, you can add a matching exception in the .wiz file.
Learn more
|
@shibburnllc the validation is failing with: |
|
@tremarkley Thanks for pointing that out. It seems like it default to that at the time of deployment, but the token is fully canonical and functions exactly as expected. It bridges 1:1 $SHIB between Here are verifiable test transactions using 0xB4C985C9fCA34C6D6A42FdA8832aA74067636F69 (Shibburn.eth): • Bridge back to ETH (via superbridge.app): • On Ethereum (proved/finalized): |
This PR adds the canonical SHIB token (Shiba Inu) to the Base token list.
The token is deployed using the OP Stack Standard Bridge, which maps SHIB from Ethereum Mainnet to Base in a fully trust-minimized and 1:1 backed manner.
Included in this PR:
• Token metadata folder for SHIB
• Token logo in required formats
• Base contract address: 0x728516d460C60DC147aE0DA3a75D3Ac0984F20Ed
• Ethereum contract address: 0x95aD61b0a150d79219dCF64E1E6Cc01f0B64C4cE
This is the canonical representation of SHIB on Base.
Adds the canonical SHIB token on Base details, including its metadata and logo
The canonical mapping was verified by bridging SHIB from Ethereum Mainnet → Base → Ethereum using the OP Stack Standard Bridge.
Deposits and withdrawals finalized correctly, and the token behaved as expected when used in a payout contract on Base.
No additional code-level tests required for this token-entry.
Metadata