chore: Simplify op-deployer scripts: DeploySuperchain [1/N]#15014
Merged
janjakubnanista merged 14 commits intodevelopfrom Apr 1, 2025
Merged
chore: Simplify op-deployer scripts: DeploySuperchain [1/N]#15014janjakubnanista merged 14 commits intodevelopfrom
janjakubnanista merged 14 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15014 +/- ##
============================================
+ Coverage 46.42% 85.63% +39.21%
============================================
Files 1183 121 -1062
Lines 101251 6238 -95013
============================================
- Hits 47002 5342 -41660
+ Misses 50904 884 -50020
+ Partials 3345 12 -3333
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
6c6d3ec to
f8d31d9
Compare
92bf554 to
0b9201d
Compare
mslipper
approved these changes
Mar 31, 2025
Collaborator
mslipper
left a comment
There was a problem hiding this comment.
this looks good to me - what's the migration plan for the script? is the idea to merge this stack then replace deploysuperchain with deploysuperchain2?
f656312 to
1fc0a0a
Compare
bitwiseguy
pushed a commit
that referenced
this pull request
Jun 16, 2025
* chore: Base deploy script * wip: DeploySuperchain * chore: Drop unused error * chore: Rename DeployBase to BaseDeploy * fix: Typo * chore: Finish renaming, remove unused imports * chore: Lint * chore: Simplify the script * fix: Lint * chore: Forgotten import * chore: Fix typo * chore: Use bytes32 for ProtocolVersion externally * chore: Comments * chore: Lint
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
…-optimism#15014) * chore: Base deploy script * wip: DeploySuperchain * chore: Drop unused error * chore: Rename DeployBase to BaseDeploy * fix: Typo * chore: Finish renaming, remove unused imports * chore: Lint * chore: Simplify the script * fix: Lint * chore: Forgotten import * chore: Fix typo * chore: Use bytes32 for ProtocolVersion externally * chore: Comments * chore: Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An investigation PR focused on reducing the complexity of deploy scripts, taking
DeploySuperchainas a test subject. Instead of modifying the original script,DeploySuperchain2has been introduced to allow for step-by-step migration and side-by-side comparison.runmethods as internal. Any reusable deployment logic should be placed into a separate deploy script that only exposes therunmethodRelates to #14976
Notes
DeploySuperchain) has partial public functions besides the main entrypoint (and partial assertion functions). To impose a cleaner interface, I propose no such partial functions - instead, separate deployment script contracts should be defined (could be in the same file), each with only one public function (run). This way, the convention runs all the way through the codebase.