op-e2e/system: add test for minting to a delegated account#15090
Merged
sebastianst merged 9 commits intodevelopfrom Mar 31, 2025
Merged
op-e2e/system: add test for minting to a delegated account#15090sebastianst merged 9 commits intodevelopfrom
sebastianst merged 9 commits intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15090 +/- ##
===========================================
- Coverage 46.43% 42.41% -4.02%
===========================================
Files 1183 1011 -172
Lines 101030 90773 -10257
===========================================
- Hits 46911 38501 -8410
+ Misses 50787 49107 -1680
+ Partials 3332 3165 -167
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
geoknee
approved these changes
Mar 28, 2025
Contributor
geoknee
left a comment
There was a problem hiding this comment.
👏
This overall looks good. Most of my comments are about tidying up which would be great to do.
Co-authored-by: George Knee <georgeknee@googlemail.com>
Co-authored-by: George Knee <georgeknee@googlemail.com>
Contributor
Member
sebastianst
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test for minting to a delegated account.