Skip to content

op-e2e/system: add test for minting to a delegated account#15090

Merged
sebastianst merged 9 commits intodevelopfrom
meyer9/add-mint-delegated-account-test
Mar 31, 2025
Merged

op-e2e/system: add test for minting to a delegated account#15090
sebastianst merged 9 commits intodevelopfrom
meyer9/add-mint-delegated-account-test

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Mar 27, 2025

Description

Adds a test for minting to a delegated account.

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.41%. Comparing base (f21f368) to head (b9bbc99).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15090      +/-   ##
===========================================
- Coverage    46.43%   42.41%   -4.02%     
===========================================
  Files         1183     1011     -172     
  Lines       101030    90773   -10257     
===========================================
- Hits         46911    38501    -8410     
+ Misses       50787    49107    -1680     
+ Partials      3332     3165     -167     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 176 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meyer9 meyer9 marked this pull request as ready for review March 28, 2025 16:07
@meyer9 meyer9 requested review from a team as code owners March 28, 2025 16:07
@meyer9 meyer9 requested a review from mds1 March 28, 2025 16:07
@geoknee geoknee self-requested a review March 28, 2025 17:12
@geoknee geoknee self-assigned this Mar 28, 2025
@geoknee geoknee added the H-isthmus Hardfork: change is planned for isthmus upgrade label Mar 28, 2025
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

This overall looks good. Most of my comments are about tidying up which would be great to do.

meyer9 and others added 4 commits March 28, 2025 11:20
Co-authored-by: George Knee <georgeknee@googlemail.com>
Co-authored-by: George Knee <georgeknee@googlemail.com>
@Ethnical
Copy link
Contributor

Can we merge this PR @meyer9 @geoknee in your opinion or something else is missing?

@sebastianst sebastianst changed the title feat: add test for minting to a delegated account op-e2e/system: add test for minting to a delegated account Mar 31, 2025
@sebastianst
Copy link
Member

Can we merge this PR @meyer9 @geoknee in your opinion or something else is missing?

It should be converted into an actions/proof test. Tracking here #15123 so we can merge this to tick the boxes.

@sebastianst sebastianst added this pull request to the merge queue Mar 31, 2025
Merged via the queue into develop with commit b393661 Mar 31, 2025
50 checks passed
@sebastianst sebastianst deleted the meyer9/add-mint-delegated-account-test branch March 31, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

H-isthmus Hardfork: change is planned for isthmus upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments