op-e2e: Use chain specific file names for config in challenger helper#15091
Merged
protolambda merged 1 commit intodevelopfrom Apr 1, 2025
Merged
op-e2e: Use chain specific file names for config in challenger helper#15091protolambda merged 1 commit intodevelopfrom
protolambda merged 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15091 +/- ##
===========================================
- Coverage 46.51% 42.39% -4.13%
===========================================
Files 1183 1011 -172
Lines 101032 90775 -10257
===========================================
- Hits 47000 38486 -8514
+ Misses 50688 49118 -1570
+ Partials 3344 3171 -173
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
protolambda
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When updating the op-e2e fault proof helpers to support interop, the filename that l2 genesis and rollup config files were written to wasn't made chain specific. So while it looped over every chain in the dep set, it was just overwriting the same file. Now the chain ID is included in the path to make the file unique per chain.