Skip to content

op-e2e: Use chain specific file names for config in challenger helper#15091

Merged
protolambda merged 1 commit intodevelopfrom
aj/fix-helper-config-writing
Apr 1, 2025
Merged

op-e2e: Use chain specific file names for config in challenger helper#15091
protolambda merged 1 commit intodevelopfrom
aj/fix-helper-config-writing

Conversation

@ajsutton
Copy link
Contributor

Description

When updating the op-e2e fault proof helpers to support interop, the filename that l2 genesis and rollup config files were written to wasn't made chain specific. So while it looped over every chain in the dep set, it was just overwriting the same file. Now the chain ID is included in the path to make the file unique per chain.

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.39%. Comparing base (db1f42d) to head (c0f228b).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15091      +/-   ##
===========================================
- Coverage    46.51%   42.39%   -4.13%     
===========================================
  Files         1183     1011     -172     
  Lines       101032    90775   -10257     
===========================================
- Hits         47000    38486    -8514     
+ Misses       50688    49118    -1570     
+ Partials      3344     3171     -173     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 179 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@protolambda protolambda added this pull request to the merge queue Apr 1, 2025
Merged via the queue into develop with commit 8c91990 Apr 1, 2025
50 checks passed
@protolambda protolambda deleted the aj/fix-helper-config-writing branch April 1, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments