Conversation
joshklop
force-pushed
the
joshklop/fix-regolith-test
branch
2 times, most recently
from
afe2dd2 to
39f49f3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19574 +/- ##
==========================================
- Coverage 75.5% 75.0% -0.6%
==========================================
Files 675 536 -139
Lines 71571 64316 -7255
==========================================
- Hits 54102 48243 -5859
+ Misses 17325 15929 -1396
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
reviewed
Mar 17, 2026
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
LGTM once op-geth is pointing at a merged fix.
joshklop
force-pushed
the
joshklop/fix-regolith-test
branch
2 times, most recently
from
5ff1ed5 to
bc5ba0f
Compare
Contributor
Author
Done. This is checked in ci now as well. |
geoknee
approved these changes
Mar 17, 2026
The goal of the test is to assert that system deposit transactions cannot be present in post-Regolith blocks. Previously, the test would erroneously succeed by attempting to create a block with too much gas. When combined with a small change in op-geth, the test now succeeds for the correct reason.
joshklop
force-pushed
the
joshklop/fix-regolith-test
branch
from
bc5ba0f to
ac3cfb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the test is to assert that system deposit transactions cannot be present in post-Regolith blocks.
Previously, the test would erroneously succeed by attempting to create a block with too much gas.
When combined with a small change in op-geth, the test now succeeds for the correct reason.