Suggest actual mode map name: solidity-mode-map #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@durantschoon Hey thanks for the PR. I think you are correct, this is a mistake in the Readme. I will merge this but can you first please squash the 2 commits into one? |
LefterisJP
requested changes
Sep 21, 2018
Collaborator
LefterisJP
left a comment
LefterisJP
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please squash the 2 commits into one.
Using `map` causes an error. Using `solidity-mode-map` fixes it for me.
durantschoon
force-pushed
the
master
branch
from
11caacb to
c643e1e
Compare
Contributor
Author
|
They've been squashed. @LefterisJP |
LefterisJP
approved these changes
Oct 4, 2018
Collaborator
|
@durantschoon Thanks a lot! And sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
mapcauses an error. Usingsolidity-mode-mapfixes it for me.