Expand currency test suite to fuzz test using float values#103
Closed
dilatebrave wants to merge 1 commit intoethereum:masterfrom
Closed
Expand currency test suite to fuzz test using float values#103dilatebrave wants to merge 1 commit intoethereum:masterfrom
dilatebrave wants to merge 1 commit intoethereum:masterfrom
Conversation
Member
|
Hrm, looking at this I think it actually makes it clear that we must disallow floats or implement some kind of internal validation that rejects floats which cannot be accurately converted. I'm skeptical that we can do the later, so.. would you be up for changing this PR to instead reject |
Member
|
closing this as the removal of float support should be done in a separate PR |
pacrob
added a commit
to pacrob/eth-utils
that referenced
this pull request
Dec 4, 2023
* add pre-commit * run pre-commit * skip lint on README.md as it breaks template filling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #102
I have add test_to_wei_float in test_currency_tools, but the test fail
In
to_wei, should we check decimal precision of floats to throw an error instead of silently roundup the return valueint(result_value)?Cute Animal Picture