engine: Restrict no-reorg to the prefix of known finalized#786
Merged
fjl merged 1 commit intoethereum:mainfrom Apr 23, 2026
Merged
engine: Restrict no-reorg to the prefix of known finalized#786fjl merged 1 commit intoethereum:mainfrom
fjl merged 1 commit intoethereum:mainfrom
Conversation
Contributor
|
Just a comment to leave somewhere, but I think these types of reorgs going back on the canonical chain can only happen up to the "Justified" hash instead of the finalized one, eg. most validators are malicious and start voting on top of the justified root but empty. |
jihoonsong
added a commit
to jihoonsong/execution-apis
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #770 and introduces the following changes:
-38006: Too deep reorgerror to handle the case when EL client cannot do a reorg due to the depth being beyond client's reorg capability. This depth is supposed to be implementation specificFor detail see discussion in #770 thread.