engine: add targetGasLimit to PayloadAttributesV4#796
Conversation
|
LGTM! Just to note, this means the EL has to then determine the block.gas_limit based on the target_gas_limit, e.g.: |
should the engine spec have more details about this? from the EL side nothing should change, just the source from where they get the target gas limit changes |
mkalinin
left a comment
There was a problem hiding this comment.
The spec change looks good to me 👍 Is there a consensus among CL and EL devs on the acceptance of this change?
we've discussed this on ACDT 79 yesterday, there was no opposition to this but we should probably get approvals before merging this change |
|
I think this must be bundled together with the removal of gas limit target flags on the EL side. Otherwise the expected behaviour might be unknown. If we merge this in, it would be good for EL teams to start signalling that the EL side gas limit flag will be deprecated post glamsterdam, and probably following the fork the flag should just go away completely. |
Adds
targetGasLimittoPayloadAttributesV4so that the CL can pass the target gas limit to the EL onengine_forkchoiceUpdatedV4, instead of relying on a static flag on the EL side for local building.This is useful for several reasons
Based on #608 (credit to @mcdee)