Skip to content

fix(plugins/consume-engine): Fix Engine API error check #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marioevz merged 1 commit into from
Jan 27, 2025
Merged

fix(plugins/consume-engine): Fix Engine API error check #1133

marioevz merged 1 commit into from
Jan 27, 2025

Conversation

@marioevz
Copy link
Member

@marioevz marioevz commented Jan 27, 2025 •
edited
Loading

🗒️ Description

Fixes the consume engine from failing a test when the correct and expected Engine API error code is returned.

Thanks to the Reth team for raising this issue!

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:consume Scope: Consume command suite labels Jan 27, 2025
@marioevz marioevz requested a review from danceratopz January 27, 2025 15:46
danceratopz
danceratopz approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit 5f84ce4 into main Jan 27, 2025
21 checks passed
@marioevz marioevz deleted the fix-consume-engine-error-check branch January 27, 2025 15:54
@danceratopz danceratopz mentioned this pull request Jan 28, 2025
Merged
skylenet pushed a commit to ethpandaops/pectra-devnets that referenced this pull request Jan 28, 2025
@danceratopz
update devnet-5 hive flags (#41)
59c6e93 
Pins the EEST simulator branch to the `pectra-devnet-5@v1.3.0post1` tag
to include ethereum/execution-spec-tests#1133
which fixes the Engine API error checks in `eest/consume-engine`.
@danceratopz danceratopz mentioned this pull request Jan 28, 2025
Merged
2 tasks
marioevz added a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
@marioevz
fix(plugins/consume-engine): Fix Engine API error check (ethereum#1133)
9d71501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees

No one assigned

Labels

scope:consume Scope: Consume command suite type:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marioevz @danceratopz