chore(tests): group mem-heavy tests together in xdist #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests make heavy use of `lru_cache`. Others are just memory hungry. By grouping these tests onto a single xdist worker, we consolidate caches and prevent multiple big-memory tests from running at the same time. In some _very_ rough benchmarks, I see a reduction in memory use of about 1.2GB on my local machine.
spencer-tb
approved these changes
Sep 16, 2025
Collaborator
spencer-tb
left a comment
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM!! cc @danceratopz
danceratopz
approved these changes
Sep 17, 2025
Member
danceratopz
left a comment
danceratopz
left a comment
There was a problem hiding this comment.
Amazing, thanks @SamWilsn!
danceratopz
changed the title
danceratopz
changed the title
Member
|
Really nice addition, I tagged as |
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Some tests make heavy use of
lru_cache. Others are just memory hungry. By grouping these tests onto a single xdist worker, we consolidate caches and prevent multiple big-memory tests from running at the same time.In some very rough benchmarks, I see a reduction in memory use of about 1.2GB on my local machine.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.