Skip to content

refactor(ethereum_clis): move TransitionTool.verify_fixture() to FixtureConsumer #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marioevz merged 6 commits into from
Feb 19, 2025
Merged

refactor(ethereum_clis): move TransitionTool.verify_fixture() to FixtureConsumer #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7640fb3
refactor(ethereum_clis): move `TransitionTool.verify_fixture()` to `S…
danceratopz Nov 4, 2024
004bb1f
rename function
marioevz Feb 18, 2025
a0cac29
Remove duplicate parametrization
marioevz Feb 18, 2025
03283a5
Rename `t8n_subcommand` to `subcommand`
marioevz Feb 18, 2025
137bdc8
Refactor `FixtureConsumer`
marioevz Feb 18, 2025
6119803
docs: reword changelog
marioevz Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Test fixtures for use by clients are available for each release on the [Github r
- 🔀 Make `BaseFixture` able to parse any fixture format such as `BlockchainFixture` ([#1210](https://github.com/ethereum/execution-spec-tests/pull/1210)).
- ✨ Blockchain and Blockchain-Engine tests now have a marker to specify that they were generated from a state test, which can be used with `-m blockchain_test_from_state_test` and `-m blockchain_test_engine_from_state_test` respectively ([#1220](https://github.com/ethereum/execution-spec-tests/pull/1220)).
- ✨ Blockchain and Blockchain-Engine tests that were generated from a state test now have `blockchain_test_from_state_test` or `blockchain_test_engine_from_state_test` as part of their test IDs ([#1220](https://github.com/ethereum/execution-spec-tests/pull/1220)).
- 🔀 Refactor `ethereum_test_fixtures` and `ethereum_clis` to create `FixtureConsumer` and `FixtureConsumerTool` classes which abstract away the consumption process used by `consume direct` ([#935](https://github.com/ethereum/execution-spec-tests/pull/935)).

### 📋 Misc

Expand Down
10 changes: 7 additions & 3 deletions src/ethereum_clis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,29 @@
from .clis.ethereumjs import EthereumJSTransitionTool
from .clis.evmone import EvmoneExceptionMapper, EvmOneTransitionTool
from .clis.execution_specs import ExecutionSpecsTransitionTool
from .clis.geth import GethTransitionTool
from .clis.geth import GethFixtureConsumer, GethTransitionTool
from .clis.nimbus import NimbusTransitionTool
from .ethereum_cli import CLINotFoundInPathError, UnknownCLIError
from .fixture_consumer_tool import FixtureConsumerTool
from .transition_tool import TransitionTool
from .types import Result, TransitionToolOutput

TransitionTool.set_default_tool(ExecutionSpecsTransitionTool)
FixtureConsumerTool.set_default_tool(GethFixtureConsumer)

__all__ = (
"BesuTransitionTool",
"CLINotFoundInPathError",
"EthereumJSTransitionTool",
"EvmoneExceptionMapper",
"EvmOneTransitionTool",
"ExecutionSpecsTransitionTool",
"FixtureConsumerTool",
"GethFixtureConsumer",
"GethTransitionTool",
"EvmoneExceptionMapper",
"NimbusTransitionTool",
"Result",
"TransitionTool",
"TransitionToolOutput",
"CLINotFoundInPathError",
"UnknownCLIError",
)
Loading