Implement check for fixtures version #1166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In |
Contributor
Author
I think |
Contributor
|
The issue has been fixed in #1183 |
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
* ✨ feat(gentest): Type 2 transaction * ✨ feat: Source of truth for Tx model * 🥢 nit: Casting to tx * gentest: src/cli/gentest/tests/test_cli.py refactor * fix(rpc): Adapt client's response to our model * fix(rpc): More fixes * fix(rpc): Use pydantic's AliasChoice --------- Co-authored-by: raxhvl <raxhvl@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
download_fixtures method doesn't check for fixture version and re-downloads fixtures even when the same version already exists on the location.
Related to Issue #728
How was it fixed?
Implemented a mechanism that stores the URL while downloading fixtures and compares it with the URL used on subsequent function calls. Since the URL changes on a version change, we can know if the version has been changed and if we need to re-download the fixtures. Otherwise, we can skip the download.
Cute Animal Picture