chore(test-types): adds extra modifier validation; adds unit tests

[fselmo]

🗒️ Description

From comment on EthR&D here, adds missing sanity check validations to BAL modifiers. These are currently not producing any errors but could allow some to slip through if not addressed.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (e8e9c38) to head (e48d4e0).

Additional details and impacted files

@@               Coverage Diff                @@
##           forks/amsterdam    #2710   +/-   ##
================================================
  Coverage            86.47%   86.47%           
================================================
  Files                  599      599           
  Lines                37632    37632           
  Branches              3795     3795           
================================================
  Hits                 32542    32542           
  Misses                4526     4526           
  Partials               564      564           

Flag	Coverage Δ
unittests	86.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[felix314159]

i think there is a state leak bug, added a test to show it. run with

uv run pytest packages/testing/src/execution_testing/test_types/tests/test_block_access_list_modifiers.py -v -s -k reused_callable

feel free to fix

[felix314159]

see above, forgot to mark it as review comment

[fselmo]

i think there is a state leak bug, added a test to show it. run with

@felix314159 there sure was, thanks for catching 👌🏼. This was the case in a few places... added some unit tests for that too and patched this up. Ready for a review again 👀 .

Rebased and did a hasher compare as a sanity check -- no difs on the invalid tests compared to forks/amsterdam.