chore(tests): restore and extend Amsterdam ported static skip list#2732
Merged
spencer-tb merged 1 commit intoethereum:eips/amsterdam/eip-8037from Apr 20, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8037 #2732 +/- ##
==========================================================
Coverage ? 88.18%
==========================================================
Files ? 524
Lines ? 31120
Branches ? 3036
==========================================================
Hits ? 27444
Misses ? 3161
Partials ? 515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reintroduces `amsterdam_skip_list.txt` and `conftest.py` from `devnets/bal/3` (commit 5913038) which were removed from this branch. The skip list entries are matched via substring against the pytest nodeid, so `conftest.py` now strips the fixture-format token (e.g. `-blockchain_test_from_state_test`) that pytest inserts inside the parametrize id before comparing. The skip list is extended with 2017 additional test variants that fail on the current `-m blockchain_test` Amsterdam fill and were not present when the original list was generated. Ported static fill at Amsterdam now passes cleanly with 9388 passed and 2550 skipped.
spencer-tb
force-pushed
the
eips/amsterdam/eip-8037-restore-ported-static-skip-list
branch
from
e24cddd to
1600b52
Compare
spencer-tb
merged commit e3738ca
into
ethereum:eips/amsterdam/eip-8037
14 of 15 checks passed
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 21, 2026
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 21, 2026
spencer-tb
added a commit
that referenced
this pull request
Apr 21, 2026
fselmo
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Reintroduces the Amsterdam ported static skip list (originally landed on
devnets/bal/3). This is a stop gap solution until we actually sit down and fix the remaining static tests. @kclowes has already made some efforts here with:The underlying gas limit updates in the skipped test cases remain future work, tracked by the
TODOinconftest.py.🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.