Skip to content

chore(specs): add final decorator#2934

Open
SamWilsn wants to merge 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:final!
Open

chore(specs): add final decorator#2934
SamWilsn wants to merge 1 commit into
ethereum:forks/amsterdamfrom
SamWilsn:final!

Conversation

@SamWilsn
Copy link
Copy Markdown
Contributor

🗒️ Description

mypyc can use the @final decorator for optimizations, so might as well add it.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn SamWilsn requested a review from Carsons-Eels May 28, 2026 16:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 94.36997% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.52%. Comparing base (d7def91) to head (b503630).

Files with missing lines Patch % Lines
src/ethereum/trace.py 0.00% 10 Missing ⚠️
src/ethereum/merkle_patricia_trie.py 0.00% 4 Missing ⚠️
src/ethereum/state.py 0.00% 4 Missing ⚠️
src/ethereum/genesis.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2934      +/-   ##
===================================================
+ Coverage            90.49%   90.52%   +0.02%     
===================================================
  Files                  535      535              
  Lines                32430    32712     +282     
  Branches              3012     3012              
===================================================
+ Hits                 29349    29613     +264     
- Misses                2563     2581      +18     
  Partials               518      518              
Flag Coverage Δ
unittests 90.52% <94.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant