Skip to content

✨ feat(tests): Disallow empty change set for storage slot#2945

Open
raxhvl wants to merge 2 commits into
ethereum:forks/amsterdamfrom
raxhvl:feat/eip-7928-empty-storage-set
Open

✨ feat(tests): Disallow empty change set for storage slot#2945
raxhvl wants to merge 2 commits into
ethereum:forks/amsterdamfrom
raxhvl:feat/eip-7928-empty-storage-set

Conversation

@raxhvl
Copy link
Copy Markdown
Member

@raxhvl raxhvl commented Jun 1, 2026

🗒️ Description

Adds a test to ensure clients reject storage slots with empty changes

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (810c184) to head (e2f5a54).
⚠️ Report is 13 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2945      +/-   ##
===================================================
+ Coverage            90.44%   90.49%   +0.05%     
===================================================
  Files                  535      535              
  Lines                32439    32430       -9     
  Branches              3012     3012              
===================================================
+ Hits                 29338    29349      +11     
+ Misses                2573     2563      -10     
+ Partials               528      518      -10     
Flag Coverage Δ
unittests 90.49% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raxhvl raxhvl marked this pull request as ready for review June 1, 2026 08:14
@raxhvl raxhvl changed the title ✨ feat: Disallow empty change set for storage slot ✨ feat(tests): Disallow empty change set for storage slot Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant