cmd/swarm, swarm/api: bzzr improve + networkid prio #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zelig don't know what's up with travis-ci but the code passes all tests here locally. |
zelig
suggested changes
Jan 27, 2017
Contributor
zelig
left a comment
zelig
left a comment
There was a problem hiding this comment.
very good, thanks for taking the trouble.
Two tiny things:
- explicit field names on imported struct in server_test
- please consider removing debug log lines in server_test
- remove commented out code and import lines
swarm/api/http/server_test.go
Outdated
Contributor
There was a problem hiding this comment.
go vet complains on travis about anonymous fields for imported struct types. You need to explicitly specify the field names here.
swarm/api/manifest.go
Outdated
Contributor
There was a problem hiding this comment.
try not to leave commented out bits in the code
fixes ethereum#3444 fixes ethereum#3494 networkid override Added comments to explain why test against 0 appears twice * Command line overrides saved config, saved config overrides system default --- fixes ethereum#3476 bzzr get with path Finally a hopefully clean commit for this PR Added check for empty path to avoid SIGSEGV in path parser and resolver Added requested tests for empty path and non-existing manifest. However signature for StartHTTPServer had changed. Now it's hacked as so: StartHttpServer(api.API, &Server{Addr: "127.0.0.1:8504", CorsString: ""}) * Parse url before resolve when path and ENS is supplied, example * swarm/api/http proxy server test for retrieval of subpath through get * Removed nil entry assignment on subtrie leaf in recursive key retrieval * Cleaned up path-or-no-path condition in proxy server get handler * swarm: processed with gofmt refers to lash/go-ethereum@90daa7a * swarm: Added public access method Parse alias to parse * swarm: processed with gofmt References 2ec3fd7 * Rename parse to Parse, removed alias
nolash
force-pushed
the
bzzpathfix_real5
branch
from
7030338 to
7669c5b
Compare
karalabe
reviewed
Jan 30, 2017
| @@ -0,0 +1,117 @@ | |||
| package http | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3444
fixes #3494
networkid override
Added comments to explain why test against 0 appears twice
fixes #3476
bzzr get with path
Finally a hopefully clean commit for this PR
Added check for empty path to avoid SIGSEGV in path parser and resolver
Added requested tests for empty path and non-existing manifest.
However signature for StartHTTPServer had changed.
Now it's hacked as so: