Skip to content

cmd/geth, cmd/swarm: Fix to close file handler appropriately #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2017
Merged

cmd/geth, cmd/swarm: Fix to close file handler appropriately #3624

merged 1 commit into from
Jan 30, 2017

Conversation

@kaneshin
Copy link
Contributor

@kaneshin kaneshin commented Jan 29, 2017 •
edited
Loading

It must call Close after os.Open.

karalabe
karalabe approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit f3c368c into ethereum:master Jan 30, 2017
@karalabe karalabe added this to the 1.5.8 milestone Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karalabe karalabe karalabe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.8

Development

Successfully merging this pull request may close these issues.

2 participants

@kaneshin @karalabe