Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a repository auto-review configuration and enforces a new required frontmatter field Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.coderabbit.yaml (1)
102-103: Make approach cross-reference checks deterministic.The rule is good, but without a fixed section/link format in
approaches/_template.md, reviewers will apply it inconsistently. Define exactly where links must appear and accepted formats.♻️ Proposed fix
Approach cards MUST link to both the use case they address and the patterns they combine. - Flag if no pattern or use case cross-references are present. + Required location: `## Architecture and Design Choices`. + Required format: at least one markdown link to `use-cases/*.md` and one to `patterns/*.md`. + Flag if either link type is missing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.coderabbit.yaml:
- Line 51: Update the patterns rule block in .coderabbit.yaml so its tone/source
reference points to the correct patterns style document (or the global style
doc) instead of referencing "vendors/README.md"; locate the patterns rule block
(the entry containing the "Tone:" guidance) and replace the "vendors/README.md"
reference with the proper patterns style source identifier to prevent reviewer
confusion.
- Around line 39-46: The CI rule requiring a crops_profile in frontmatter
disagrees with the code validators; make the requirement consistent by: update
the JSON schema named "pattern" to add "crops_profile" to the required array and
define its properties (cr, os, privacy, security) with the exact enums (cr:
high|medium|low|none, os: yes|partial|no, privacy: full|partial|none, security:
high|medium|low); update the validator function validatePatterns (or equivalent
in the patterns validation script) to either rely on the updated schema
validation or add an explicit check that frontmatter.crops_profile exists and
its fields match the enums, emitting a clear error message; and adjust the CI
rule text in the CROPS section of .coderabbit.yaml to match this enforced
requirement and error wording so CI, schema, and review guidance stay aligned.
- Around line 31-32: The current glob "patterns/**/*.md" in .coderabbit.yaml
(the path entry under path: "patterns/**/*.md" with the instructions field) is
too broad and matches template/README files; update the path patterns themselves
rather than the informational instructions: either use negation (if
path_instructions supports it) by adding exclusions like
"!patterns/**/_template.md" and "!patterns/**/README.md", or tighten the include
pattern to exclude leading underscores/README (e.g., only match files not
starting with "_" or not named README) so that files like _template.md and
README.md are not matched by patterns/**/*.md.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.coderabbit.yaml (1)
54-55:⚠️ Potential issue | 🟠 MajorThe README/_template bleed-through is still present in the non-pattern rules.
Lines 54, 81, 95, and 108 still use
**/*.md, so the vendor/use-case/approach/jurisdiction card instructions will also apply to each directory’sREADME.mdand_template.md. Tighten these includes to real card files, or give the non-card docs their own path rules.Also applies to: 81-82, 95-96, 108-109
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.coderabbit.yaml around lines 54 - 55, The rule globs like "vendors/**/*.md" are too broad and include README.md and _template.md; update each non-pattern rule (the entries currently using "**/*.md") to either target only actual card files (e.g., change to a more specific pattern that matches your card filenames or folders such as a dedicated cards/ subdir or filename pattern) or add explicit excludes for README.md and _template.md (negated globs like excluding "**/README.md" and "**/_template.md"); apply the same change to the other similar entries that use "**/*.md" so vendor/use-case/approach/jurisdiction card instructions no longer bleed into non-card docs.
🧹 Nitpick comments (1)
scripts/validate-patterns.js (1)
301-317: Avoid hard-coding the CROPS enums in two places.Lines 304-309 duplicate the allowed values already defined in
scripts/schemas/pattern.json, so the schema and validator can drift apart later. I’d treat the schema as the single source of truth here and keep only the contextual checks that Ajv cannot express.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/validate-patterns.js` around lines 301 - 317, Currently the allowed CROPS enums are hard-coded in the cropsFields object in validate-patterns.js (the cp variable and its loop pushing to fileErrors), which duplicates scripts/schemas/pattern.json; change the validator to read the allowed lists from the schema instead of defining cropsFields inline: load the pattern schema (from scripts/schemas/pattern.json), extract the enum arrays for crops_profile.cr, crops_profile.os, crops_profile.privacy, and crops_profile.security, and use those arrays in the existing loop that checks cp[field] and pushes to fileErrors so the schema remains the single source of truth while keeping any contextual checks Ajv can’t express.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/validate-patterns.js`:
- Around line 331-343: The code currently treats all additionalProperties errors
as warnings (fileWarnings) before the crops_profile path check can mark them as
errors; update the additionalProperties branch in the validator so it promotes
unexpected fields under crops_profile to errors: inside the error.keyword ===
'additionalProperties' case, inspect errorPath (and/or error.instancePath) and
if it startsWith('/crops_profile') push to fileErrors (e.g.,
fileErrors.push(`Schema: unexpected field '${error.params.additionalProperty}'
in frontmatter`)) otherwise keep the existing fileWarnings behavior; you can
also alternatively move the isRequiredField check above the additionalProperties
branch and use the isRequiredField boolean to decide between fileErrors and
fileWarnings.
---
Duplicate comments:
In @.coderabbit.yaml:
- Around line 54-55: The rule globs like "vendors/**/*.md" are too broad and
include README.md and _template.md; update each non-pattern rule (the entries
currently using "**/*.md") to either target only actual card files (e.g., change
to a more specific pattern that matches your card filenames or folders such as a
dedicated cards/ subdir or filename pattern) or add explicit excludes for
README.md and _template.md (negated globs like excluding "**/README.md" and
"**/_template.md"); apply the same change to the other similar entries that use
"**/*.md" so vendor/use-case/approach/jurisdiction card instructions no longer
bleed into non-card docs.
---
Nitpick comments:
In `@scripts/validate-patterns.js`:
- Around line 301-317: Currently the allowed CROPS enums are hard-coded in the
cropsFields object in validate-patterns.js (the cp variable and its loop pushing
to fileErrors), which duplicates scripts/schemas/pattern.json; change the
validator to read the allowed lists from the schema instead of defining
cropsFields inline: load the pattern schema (from scripts/schemas/pattern.json),
extract the enum arrays for crops_profile.cr, crops_profile.os,
crops_profile.privacy, and crops_profile.security, and use those arrays in the
existing loop that checks cp[field] and pushes to fileErrors so the schema
remains the single source of truth while keeping any contextual checks Ajv can’t
express.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 99a1f602-7227-41de-bc82-caf4a4ebaad6
📒 Files selected for processing (4)
.coderabbit.yamlpatterns/pattern-l2-privacy-evaluation.mdscripts/schemas/pattern.jsonscripts/validate-patterns.js
rymnc
approved these changes
Mar 18, 2026
Meyanis95
changed the title
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test to check is coderabbit review is triggered.
Summary by CodeRabbit
Chores
Documentation
Bug Fixes