Skip to content

AggregateVerify accepts publc keys and messages as separate parameters, aligning README with it.#115

Merged
hwwhww merged 1 commit intoethereum:masterfrom
SmartLayer:master
Mar 9, 2021
Merged

AggregateVerify accepts publc keys and messages as separate parameters, aligning README with it.#115
hwwhww merged 1 commit intoethereum:masterfrom
SmartLayer:master

Conversation

@SmartLayer
Copy link
Copy Markdown

@SmartLayer SmartLayer commented Dec 29, 2020

What was wrong?

The code in README.md would produce the following error:

Traceback (most recent call last):
  File "test.py", line 34, in <module>
    assert bls_pop.AggregateVerify(cls, BLSSignature(agg_sig))
TypeError: AggregateVerify() missing 1 required positional argument: 'signature'

How was it fixed?

Because AggregateVerify expects a list of public keys and a list of messages as separate arguments, it has mistaken the supplied agg_sig as the list of messages and begs for the non-existing signature list. Updating document to match the code.

Cute Animal Picture

e

Copy link
Copy Markdown
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @colourful-land. :)

@hwwhww hwwhww merged commit 18d2e80 into ethereum:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants