Skip to content
This repository was archived by the owner on May 23, 2023. It is now read-only.

Conversation

@villesundell
Copy link

Added numpy (fundamental package for scientific computing with Python) as a requirement (run-time).

Added numpy (fundamental package for scientific computing with Python) as a requirement (run-time).
@konradkonrad
Copy link
Contributor

This seems invalid at first sight, but I'll give you the chance to explain the rationale behind this PR, @villesundell ?

@villesundell
Copy link
Author

Sorry, I think this is only for "serenity"-branch (the test file in ethereum/ needs this). My bad, I can make another PR against "serenity" when I return to my computer.

@villesundell
Copy link
Author

Nope, it seems that "develop" branch also uses numpy at: ethereum/fastvm.py
Am I mistaken/misunderstood something here?

@konradkonrad
Copy link
Contributor

Hmm. To my knowledge fastvm.py is not in use, but so far just a WIP/PoC. So I'm hesitant to add numpy to the global requirements.
How did you end up with this PR? Have you successfully used fastvm.py for anything?

@villesundell
Copy link
Author

Sorry for the delay! Well, some of Vitalik's Serenity PoC instructions used test.py, as in here: https://blog.ethereum.org/2015/12/24/understanding-serenity-part-i-abstraction/

ulope added a commit to ethereum/pydevp2p that referenced this pull request Jan 10, 2017
This is necessary until a permanent solution for ethereum/pyethereum#412 
is found
@joeykrug joeykrug closed this Oct 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants