test(accounts): add assertion for expected_bytes in test_eth_account_… #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
approved these changes
Jun 3, 2025
Collaborator
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
lgtm! I added a newsfragment. Thanks for the PR 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The expected_bytes parameter in the test_eth_account_sign test was defined and provided via parametrization, but was not actually used in the test body. This resulted in a linter warning for an unused variable and missed an opportunity to verify the correctness of the message's byte representation.
How was it fixed?
Added an assertion to check that message.body matches the expected_bytes parameter. This ensures the test validates the correct byte encoding of the message and eliminates the unused variable warning.
Todo:
Cute Animal Picture